Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1016467: Enable matrix for Azure and GCP cloud providers. #1777

Merged
merged 11 commits into from
Jun 24, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented May 30, 2024

Overview

SNOW-1016467 Enable matrix for Azure and GCP cloud providers.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-CloudProviderExecutions branch 15 times, most recently from 6ae47e1 to fcb620c Compare June 6, 2024 21:25
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-CloudProviderExecutions branch 2 times, most recently from 80650f6 to 9220ca3 Compare June 18, 2024 22:12
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title SNOW-1016467: Cloud provider exclusive categories SNOW-1016467: Enable matrix for Azure and GCP cloud providers. Jun 18, 2024
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-CloudProviderExecutions branch from 8dd84d7 to 47063f4 Compare June 18, 2024 22:47
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as ready for review June 18, 2024 22:48
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner June 18, 2024 22:48
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-CloudProviderExecutions branch from 47063f4 to b6d2bd9 Compare June 20, 2024 13:15
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-CloudProviderExecutions branch from 95220bd to 2a628db Compare June 21, 2024 01:31
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-CloudProviderExecutions branch from 63e4ab1 to 4738b15 Compare June 21, 2024 17:30
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit ab4880c into master Jun 24, 2024
109 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1016467-CloudProviderExecutions branch June 24, 2024 06:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants