Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1016467: Support test Windows environment in Github actions. #1766

Merged
merged 4 commits into from
Jun 18, 2024
Merged

SNOW-1016467: Support test Windows environment in Github actions. #1766

merged 4 commits into from
Jun 18, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented May 23, 2024 •
edited
Loading

Overview

SNOW-1016467: Support test Windows environment in Github actions.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableWindowsGithubActions branch 27 times, most recently from 361c272 to 31eeecd Compare May 24, 2024 22:42
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title Snow 1016467 enable windows GitHub actions Snow 1016467: Support test Windows environment in Github actions. May 24, 2024
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableWindowsGithubActions branch 2 times, most recently from f061f44 to 68f9c65 Compare May 27, 2024 13:41
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableWindowsGithubActions branch 9 times, most recently from bc825c3 to ebcb3a6 Compare June 10, 2024 17:02
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableWindowsGithubActions branch 2 times, most recently from e4340f3 to 9043671 Compare June 11, 2024 22:41
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as ready for review June 11, 2024 22:51
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner June 11, 2024 22:51
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableWindowsGithubActions branch from 9043671 to ce82956 Compare June 12, 2024 12:50
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title Snow 1016467: Support test Windows environment in Github actions. SNOW-1016467: Support test Windows environment in Github actions. Jun 12, 2024
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jun 12, 2024
View reviewed changes
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
ci/test_windows.bat Outdated Show resolved Hide resolved
ci/test_windows.bat Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableWindowsGithubActions branch from 65bd06a to 99a2167 Compare June 12, 2024 15:24
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableWindowsGithubActions branch from 99a2167 to 8cd3648 Compare June 14, 2024 20:44
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 6a95dcc into master Jun 18, 2024
85 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1016467-EnableWindowsGithubActions branch June 18, 2024 05:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk Awaiting requested review from sfc-gh-akolodziejczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jmartinezramirez @sfc-gh-dprzybysz