Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1016467: Support test Mac environment in Github actions. #1765

Merged
merged 3 commits into from
Jun 10, 2024
Merged

SNOW-1016467: Support test Mac environment in Github actions. #1765

merged 3 commits into from
Jun 10, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented May 22, 2024 •
edited
Loading

Overview

SNOW-1016467 Support test Mac environment in Github actions.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableMacWindowsGithubActions branch 7 times, most recently from 3dba99e to 94bc939 Compare May 23, 2024 13:28
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title SNOW-1016467 Test MAC environment SNOW-1016467: Support test Mac environment in Github actions. May 23, 2024
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as ready for review May 23, 2024 13:33
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner May 23, 2024 13:33
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableMacWindowsGithubActions branch 2 times, most recently from 63b55a7 to 4c142c3 Compare May 23, 2024 13:41
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed May 23, 2024
View reviewed changes
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
ci/log_analyze_setup.sh Outdated Show resolved Hide resolved
ci/log_analyze_setup.sh Outdated Show resolved Hide resolved
ci/log_analyze_setup.sh Outdated Show resolved Hide resolved
ci/test_mac.sh Outdated Show resolved Hide resolved
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableMacWindowsGithubActions branch from 3b6c290 to 5a07b31 Compare May 23, 2024 17:48
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableMacWindowsGithubActions branch from 5a07b31 to 32343f0 Compare May 29, 2024 23:06
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1016467-EnableMacWindowsGithubActions branch from 32343f0 to 9b108dd Compare June 10, 2024 12:43
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez merged commit bfe205c into master Jun 10, 2024
61 checks passed
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez deleted the SNOW-1016467-EnableMacWindowsGithubActions branch June 10, 2024 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jmartinezramirez @sfc-gh-akolodziejczyk @sfc-gh-dprzybysz