Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1016470: Increase code coverage in JDBC part1 #1759

Merged
merged 43 commits into from
Jun 20, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented May 16, 2024

Overview

SNOW-1016470

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    • Added more testing to cover 90%
    • Fixed typos
  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review June 11, 2024 18:09
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner June 11, 2024 18:09
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title Coverage SNOW-1016470: Increase code coverage to at least 90% in JDBC Jun 11, 2024
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and rename the PR name - probably we won't achieve 90%

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1016470: Increase code coverage to at least 90% in JDBC SNOW-1016470: Increase code coverage to at 85% in JDBC Jun 20, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1016470: Increase code coverage to at 85% in JDBC SNOW-1016470: Partially Increase code coverage in JDBC Jun 20, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1016470: Partially Increase code coverage in JDBC SNOW-1016470: Increase code coverage in JDBC part1 Jun 20, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 184d6ff into master Jun 20, 2024
84 of 85 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the coverage90 branch June 20, 2024 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants