Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1226600: Add parameter to disable SAML URL check #1748

Merged
merged 7 commits into from
May 15, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Overview

SNOW-1226600

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
  • added a new option to disable the saml URL check for the Okta authenticator.
  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review May 13, 2024 16:34
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner May 13, 2024 16:34
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title SNOW-1226600 Parameter to disable SAML URL check for JDBC driver SNOW-1226600: Add parameter to disable SAML URL check May 15, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit c601137 into master May 15, 2024
35 of 37 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the disableSamlUrl branch May 15, 2024 16:48
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants