Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1213117: Wrap connection, statement and result set in try with resources(3/4) #1723

Merged
merged 15 commits into from
Apr 25, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Apr 12, 2024

Overview

SNOW-1213117

  • Wrap connection, statement and result set in try with resources

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1213117: Wrap connection, statement and result set in try with resources(3) SNOW-1213117: Wrap connection, statement and result set in try with resources(3/4) Apr 12, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review April 19, 2024 19:24
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner April 19, 2024 19:24
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 804ef67 into master Apr 25, 2024
37 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the wrapconnection-3 branch April 25, 2024 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants