SNOW-928973: Date field is returning one day less when getting through getString method #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is someone able to review and sanction this fix ? |
src/main/java/net/snowflake/client/core/arrow/DateConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/arrow/DateConverter.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/core/arrow/DateConverterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/core/arrow/DateConverterTest.java
Outdated
Show resolved
Hide resolved
…imezone in DateConverter, add helper function for useDateFormat
src/main/java/net/snowflake/client/jdbc/SnowflakeBaseResultSet.java
Outdated
Show resolved
Hide resolved
…ezone back to null to prevent BCR
src/main/java/net/snowflake/client/jdbc/SnowflakeBasicDataSource.java
Outdated
Show resolved
Hide resolved
…on parameter JDBC_GET_DATE_USE_NULL_TIMEZONE
sfc-gh-dprzybysz
approved these changes
Jul 17, 2024
sfc-gh-pfus
reviewed
Jul 18, 2024
sfc-gh-pmotacki
approved these changes
Jul 19, 2024
sfc-gh-dprzybysz
deleted the
SNOW-928973-incorrect-getString-date-field-fix
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-928973: Date field is returning one day less when getting through getString method
Fixes date field issue by setting timezone to UTC when converting from date to string and objects. For https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/761