SNOW-1299790 Delete structured type flag #1698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pmotacki
force-pushed
the
delete_structured_type_flag
branch
from
3dff843 to
e7409a8
Compare
sfc-gh-pmotacki
changed the title
sfc-gh-pmotacki
force-pushed
the
delete_structured_type_flag
branch
from
7bb1ae1 to
1067bf7
Compare
sfc-gh-pmotacki
changed the title
src/main/java/net/snowflake/client/jdbc/SnowflakeBaseResultSet.java
Outdated
Show resolved
Hide resolved
| @@ -477,4 +477,9 @@ public List<Boolean> getIsAutoIncrementList() { | |||
| public List<SnowflakeColumnMetadata> getColumnMetadata() { | |||
| return columnMetadata; | |||
| } | |||
|
|
|||
| public boolean isStructuredTypeColumn(int columnIndex) { | |||
There was a problem hiding this comment.
Is there a situation where this throws IndexOutofBoundsException?
| @@ -284,7 +283,7 @@ protected SfSqlArray getJsonArray(String obj, int columnIndex) throws SFExceptio | |||
| int columnType = ColumnTypeHelper.getColumnType(columnSubType, session); | |||
| int scale = fieldMetadata.getScale(); | |||
|
|
|||
| ArrayNode arrayNode = (ArrayNode) OBJECT_MAPPER.readTree(obj); | |||
| ArrayNode arrayNode = (ArrayNode) OBJECT_MAPPER.readTree(obj.replaceAll("undefined", "null")); | |||
There was a problem hiding this comment.
do we want to leave this?
sfc-gh-pmotacki
force-pushed
the
delete_structured_type_flag
branch
from
1660bfa to
21ff020
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.