Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1299790 - handle nulls in structured types #1695

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

sfc-gh-pmotacki
Copy link
Contributor

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner April 3, 2024 11:41
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1299790-handle-nulls branch from 86f0441 to a3beb37 Compare April 3, 2024 12:48
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1299790-handle-nulls branch from a3beb37 to 2d5f194 Compare April 3, 2024 13:39
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1299790-handle-nulls branch from 0f74e1e to 50bd387 Compare April 3, 2024 16:20
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1299790-handle-nulls branch from 8e1b1ff to 3a26dae Compare April 3, 2024 19:04
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1299790-handle-nulls branch from 88c1c6d to d1798a7 Compare April 4, 2024 07:41
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 334b44f into master Apr 4, 2024
37 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1299790-handle-nulls branch April 4, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants