Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1246554: Move public suffix list to internal package when shading #1690

Merged
merged 1 commit into from
Apr 3, 2024
Merged

SNOW-1246554: Move public suffix list to internal package when shading #1690

merged 1 commit into from
Apr 3, 2024

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Overview

SNOW-1246554

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as ready for review April 2, 2024 11:09
@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner April 2, 2024 11:09
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 55d4e6c into master Apr 3, 2024
37 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1246554-move-public-suffix-list-to-internal-package branch April 3, 2024 08:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-pfus