Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1232333 - add mapping for basic types form arrays and maps #1679

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

sfc-gh-pmotacki
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki commented Mar 21, 2024

Overview

SNOW-1259709

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1259709-array-map-simple-types branch 2 times, most recently from 4fa47d6 to 6209865 Compare March 21, 2024 10:20
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review March 21, 2024 10:44
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner March 21, 2024 10:44
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1259709-array-map-simple-types branch from 4d4e233 to e68675f Compare March 22, 2024 09:49
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1259709-array-map-simple-types branch from 09f2d09 to baf98e9 Compare March 25, 2024 10:04
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 7d7b16c into master Mar 27, 2024
34 of 36 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1259709-array-map-simple-types branch March 27, 2024 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants