Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1167986: Logs - Connection #1678

Merged
merged 11 commits into from
Apr 9, 2024
Merged

SNOW-1167986: Logs - Connection #1678

merged 11 commits into from
Apr 9, 2024

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Overview

SNOW-1167986

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner March 20, 2024 17:28
@sfc-gh-pbulawa sfc-gh-pbulawa changed the base branch from SNOW-1017605-improve-logging to SNOW-1167984-configuration March 22, 2024 15:59
@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-1167986-connection branch from 7951603 to 604ff3f Compare March 22, 2024 16:11
@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-1167984-configuration branch from 165c43c to f96275c Compare March 22, 2024 16:31
@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-1167986-connection branch from 604ff3f to 3e45b58 Compare March 22, 2024 17:10
@sfc-gh-pbulawa sfc-gh-pbulawa changed the base branch from SNOW-1167984-configuration to SNOW-1017605-improve-logging March 22, 2024 17:28
@sfc-gh-pbulawa sfc-gh-pbulawa changed the base branch from SNOW-1017605-improve-logging to SNOW-1167984-configuration March 22, 2024 17:31
Base automatically changed from SNOW-1167984-configuration to SNOW-1017605-improve-logging April 9, 2024 10:21
@sfc-gh-pbulawa
Merge remote-tracking branch 'origin/SNOW-1017605-improve-logging' into
b309eef 
SNOW-1167986-connection

# Conflicts:
#	src/test/java/net/snowflake/client/config/SFClientConfigParserTest.java
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit b19b35b into SNOW-1017605-improve-logging Apr 9, 2024
4 of 6 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-1167986-connection branch April 9, 2024 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pbulawa @sfc-gh-dprzybysz