Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1234378 Return correct column type for structs depending on the run flag #1673

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

sfc-gh-pfus
Copy link
Contributor

Overview

SNOW-1234378

Before structured types are fully implemented, we hide new functionalities behind a flag. This flag should be taken into account when deciding about column type for structs.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1234378-varchar-column-type branch 4 times, most recently from 4e40169 to 6940c71 Compare March 18, 2024 12:57
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review March 18, 2024 15:05
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner March 18, 2024 15:05
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1234378-varchar-column-type branch from 6940c71 to 42fc6d7 Compare March 19, 2024 06:33
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1234378-varchar-column-type branch 2 times, most recently from 0987335 to fbaa420 Compare March 21, 2024 11:03
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1234378-varchar-column-type branch from fbaa420 to 88786c1 Compare March 21, 2024 11:14
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit a36390a into master Mar 22, 2024
36 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1234378-varchar-column-type branch March 22, 2024 08:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants