Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1170182: Return decimal as int in ARROW results configured by flag #1666

Conversation

sfc-gh-ext-simba-jf
Copy link
Collaborator

Overview

SNOW-1170182

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Fixes #NNNN

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  2. Please describe how your code solves the related issue.

    Added new connection property jdbc_arrow_treat_decimal_as_int to allow for resultSet.getObject for certain numeric types to report the object class more consistently.

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner March 11, 2024 08:42
@sfc-gh-ext-simba-jf
Copy link
Collaborator Author

Hi @sfc-gh-dprzybysz I'm not able to open the jenkins test failures. Can you share the log with me somehow?

@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title New Connection string property jdbc_arrow_treat_decimal_as_int SNOW-1170182: Return decimal as int in ARROW results configured by flag Mar 15, 2024
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit f279079 into master Mar 15, 2024
36 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the Connection-string-property-JDBC_ARROW_TREAT_DECIMAL_AS_INT branch March 15, 2024 10:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants