Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-974575 Structured type array map #1654

Merged
merged 2 commits into from
Mar 13, 2024
Merged

SNOW-974575 Structured type array map #1654

merged 2 commits into from
Mar 13, 2024

Conversation

sfc-gh-pmotacki
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki commented Mar 1, 2024 •
edited
Loading

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pmotacki sfc-gh-pmotacki changed the title Structured type array map SNOW-974575 Structured type array map Mar 1, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review March 1, 2024 12:44
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner March 1, 2024 12:44
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the structuredType-array-map branch 2 times, most recently from 9588be8 to 1508612 Compare March 4, 2024 07:44
sfc-gh-pfus
sfc-gh-pfus reviewed Mar 4, 2024
View reviewed changes
src/main/java/net/snowflake/client/core/ConvertersFactory.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFBaseResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFBaseResultSet.java Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SfSqlArray.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeBaseResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/util/TypeConverter.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/util/TypeConverter.java Outdated Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java Outdated Show resolved Hide resolved
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Mar 5, 2024
View reviewed changes
src/main/java/net/snowflake/client/core/SFArrowResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFBaseResultSet.java Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFResultSetMetaData.java Show resolved Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeResultSetV1.java Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java Outdated Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the structuredType-array-map branch 2 times, most recently from 4c9a2b0 to 7d1d80e Compare March 7, 2024 16:19
sfc-gh-pfus
sfc-gh-pfus reviewed Mar 8, 2024
View reviewed changes
src/main/java/net/snowflake/client/core/SFBaseResultSet.java Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/core/SFJsonResultSet.java Show resolved Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeBaseResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeBaseResultSet.java Outdated Show resolved Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeColumnMetadata.java Outdated Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java Outdated Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ShortTypeWrapper.java Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the structuredType-array-map branch 2 times, most recently from 2f24af9 to 7e690e6 Compare March 11, 2024 15:04
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the structuredType-array-map branch from bdd1886 to a450023 Compare March 12, 2024 09:07
@sfc-gh-pmotacki
SNOW-974575 Implementation of methods: getArray getLists getMap
20987ed 
SNOW-974575 Implementation of methods: getArray getLists getMap

SNOW-974575 Implementation of methods: getArray getLists getMap

SNOW-974575 Implementation of methods: getArray getLists getMap

SNOW-974575 Implementation of methods: getArray getLists getMap

SNOW-974575 Implementation of methods: getArray getLists getMap

SNOW-974575 Implementation of methods: getArray getLists getMap
@sfc-gh-pmotacki
SNOW-974575 Fixes after code review
2c611c7 
SNOW-974575 Fixes after code review

SNOW-974575 Fixes after code review

SNOW-974575 Fixes after code review

SNOW-974575 Fixes after code review

SNOW-974575 Fixes after code review

SNOW-974575 Fixes after code review
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the structuredType-array-map branch from a450023 to 2c611c7 Compare March 12, 2024 18:28
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 75c57f2 into master Mar 13, 2024
34 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the structuredType-array-map branch March 13, 2024 07:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pmotacki @sfc-gh-dprzybysz @sfc-gh-pfus