-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-969794 Arrow native structured type #1649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-dheyman
force-pushed
the
arrow-native-structuredType
branch
from
March 7, 2024 15:20
fe9e728
to
2cfa1e9
Compare
sfc-gh-dheyman
changed the title
Arrow native structured type
SNOW-969794 Arrow native structured type
Mar 14, 2024
sfc-gh-pfus
reviewed
Mar 14, 2024
src/main/java/net/snowflake/client/core/SqlInputTimestampUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/arrow/BigIntToTimeConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/arrow/ThreeFieldStructToTimestampTZConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/arrow/TwoFieldStructToTimestampTZConverter.java
Outdated
Show resolved
Hide resolved
sfc-gh-pmotacki
requested changes
Mar 14, 2024
src/main/java/net/snowflake/client/core/arrow/StructuredTypeDateTimeConverter.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/arrow/TwoFieldStructToTimestampNTZConverter.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/arrow/ThreeFieldStructToTimestampTZConverter.java
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java
Outdated
Show resolved
Hide resolved
sfc-gh-pmotacki
requested changes
Mar 21, 2024
src/main/java/net/snowflake/client/core/arrow/StructuredTypeDateTimeConverter.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/arrow/StructuredTypeDateTimeConverter.java
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java
Show resolved
Hide resolved
sfc-gh-pfus
reviewed
Mar 22, 2024
src/main/java/net/snowflake/client/core/arrow/StructConverter.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/core/SqlInputTimestampUtilTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java
Show resolved
Hide resolved
sfc-gh-pmotacki
approved these changes
Mar 22, 2024
sfc-gh-pfus
approved these changes
Mar 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Native arrow structured types support
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.