Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1045548: Set the http request socket timeout #1638

Closed
wants to merge 1 commit into from

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Feb 14, 2024

Overview

SNOW-1045548

Pre-review self checklist

  • The code is correctly formatted (run mvn -P check-style validate)
  • I don't expose unnecessary new public API (run mvn verify and inspect target/japicmp/japicmp.html)
  • Pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1045548 - RT flaky test.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    The rest request was stuck on execution thus adding the socket timeout should fix the issue.

@sfc-gh-pbulawa sfc-gh-pbulawa marked this pull request as ready for review February 15, 2024 09:14
@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner February 15, 2024 09:14
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1045548 branch April 8, 2024 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants