Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1003959: Implement toString() in SnowflakePreparedStatementV1 #1604

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

sfc-gh-wfateem
Copy link
Collaborator

@sfc-gh-wfateem sfc-gh-wfateem commented Jan 12, 2024

Invoking the PreparedStatement's toString() method will now return the actual SQL query and
query ID if available rahter than the object's hashCode. This is helpful when using features
in frameworks like Spring Boot to monitor and log information about slow running queries.

Overview

SNOW-1003959

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1003959: Slow query in spring boot not showing the SQL executed. #1601

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

Invoking the PreparedStatement's toString() method will now return the actual SQL query and
query ID if available rahter than the object's hashCode. This is helpful when using features
in frameworks like Spring Boot to monitor and log information about slow running queries.
@sfc-gh-wfateem sfc-gh-wfateem marked this pull request as ready for review January 12, 2024 18:27
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-wfateem sfc-gh-wfateem merged commit 0bb7138 into master Jan 15, 2024
36 checks passed
@sfc-gh-wfateem sfc-gh-wfateem deleted the SNOW-1003959 branch January 15, 2024 14:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1003959: Slow query in spring boot not showing the SQL executed.
2 participants