Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-909180: Pass query id in exceptions from file agent #1581

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz commented Dec 7, 2023

SNOW-909180: Pass query id in exceptions from file agent

  • Added new methods with query id passed as parameters
  • Deprecating methods without query id paramter

@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the base branch from SNOW-909180-set-query-id-for-failed-statements to master December 7, 2023 13:25
@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as ready for review December 7, 2023 16:49
@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner December 7, 2023 16:49
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-909180-pass-query-id-in-exceptions-from-file-agent branch 5 times, most recently from a99469d to 0c9a257 Compare December 11, 2023 09:18
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-909180-pass-query-id-in-exceptions-from-file-agent branch 2 times, most recently from ed42df0 to 999540c Compare December 11, 2023 11:34
@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as draft December 11, 2023 12:08
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-909180-pass-query-id-in-exceptions-from-file-agent branch from 999540c to 948e1be Compare December 11, 2023 12:59
@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as ready for review December 11, 2023 13:01
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-909180-pass-query-id-in-exceptions-from-file-agent branch 2 times, most recently from e3065c2 to 04b0834 Compare December 12, 2023 09:11
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-909180-pass-query-id-in-exceptions-from-file-agent branch from 04b0834 to 8221ec2 Compare January 2, 2024 07:47
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 55e5b15 into master Jan 2, 2024
24 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-909180-pass-query-id-in-exceptions-from-file-agent branch January 2, 2024 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants