-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-909180: Pass query id in exceptions from file agent #1581
Merged
sfc-gh-dprzybysz
merged 1 commit into
master
from
SNOW-909180-pass-query-id-in-exceptions-from-file-agent
Jan 2, 2024
Merged
SNOW-909180: Pass query id in exceptions from file agent #1581
sfc-gh-dprzybysz
merged 1 commit into
master
from
SNOW-909180-pass-query-id-in-exceptions-from-file-agent
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-dprzybysz
changed the base branch from
SNOW-909180-set-query-id-for-failed-statements
to
master
December 7, 2023 13:25
sfc-gh-dprzybysz
force-pushed
the
SNOW-909180-pass-query-id-in-exceptions-from-file-agent
branch
5 times, most recently
from
December 11, 2023 09:18
a99469d
to
0c9a257
Compare
sfc-gh-pfus
reviewed
Dec 11, 2023
src/main/java/net/snowflake/client/jdbc/SnowflakeSQLLoggedException.java
Outdated
Show resolved
Hide resolved
sfc-gh-dprzybysz
force-pushed
the
SNOW-909180-pass-query-id-in-exceptions-from-file-agent
branch
2 times, most recently
from
December 11, 2023 11:34
ed42df0
to
999540c
Compare
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/cloud/storage/SnowflakeGCSClient.java
Outdated
Show resolved
Hide resolved
sfc-gh-dprzybysz
force-pushed
the
SNOW-909180-pass-query-id-in-exceptions-from-file-agent
branch
from
December 11, 2023 12:59
999540c
to
948e1be
Compare
sfc-gh-pfus
approved these changes
Dec 11, 2023
sfc-gh-mhofman
requested changes
Dec 11, 2023
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
Outdated
Show resolved
Hide resolved
sfc-gh-igarish
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sfc-gh-dprzybysz
force-pushed
the
SNOW-909180-pass-query-id-in-exceptions-from-file-agent
branch
2 times, most recently
from
December 12, 2023 09:11
e3065c2
to
04b0834
Compare
sfc-gh-mhofman
approved these changes
Dec 12, 2023
sfc-gh-dstempniak
approved these changes
Dec 12, 2023
sfc-gh-dprzybysz
force-pushed
the
SNOW-909180-pass-query-id-in-exceptions-from-file-agent
branch
from
January 2, 2024 07:47
04b0834
to
8221ec2
Compare
SonarQube Quality Gate |
sfc-gh-dprzybysz
deleted the
SNOW-909180-pass-query-id-in-exceptions-from-file-agent
branch
January 2, 2024 11:35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-909180: Pass query id in exceptions from file agent