SNOW-980046 Make QueryStatus thread safe #1571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-980046-query-status-thread-safety
branch
2 times, most recently
from
40ea6d6 to
c3e3e71
Compare
sfc-gh-pfus
force-pushed
the
SNOW-980046-query-status-thread-safety
branch
from
c3e3e71 to
fe0ed36
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-980046
QueryStatus was an enum, but it also had a state (error description and code). When one query status set one of these fields, it reflected on all places where the same query status was used.
The solution replaces QueryStatus enum with class. This class creates instances for each call and on the same time - it keeps backward compatibility from compilation and equality perspective.