Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-931788: Increase code coverage with CodeCov #1537

Merged
merged 3 commits into from
Oct 19, 2023
Merged

SNOW-931788: Increase code coverage with CodeCov #1537

merged 3 commits into from
Oct 19, 2023

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Oct 19, 2023 •
edited
Loading

Overview

SNOW-931788
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/686

Add tests to increase coverage in SessionUtil(55.01%), SnowflakeDriver(73.12%) and HttpClientSettingsKey(78.18%).

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #686

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review October 19, 2023 19:18
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner October 19, 2023 19:18
sfc-gh-igarish
sfc-gh-igarish approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit b084129 into master Oct 19, 2023
12 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the SNOW-931788-codecov-coverage branch October 19, 2023 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-jl @sfc-gh-igarish