Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 937198 use new images #1536

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Snow 937198 use new images #1536

merged 2 commits into from
Nov 15, 2023

Conversation

sfc-gh-pfus
Copy link
Contributor

@sfc-gh-pfus sfc-gh-pfus commented Oct 18, 2023 •
edited
Loading

Overview

SNOW-937197 SNOW-837198

  1. Provided new image for Java 8 - based on new centos version
  2. Provided images for Java 11 and 17
  3. Updated dependencies to work on Java 8, 11 and 17

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-937198-use-new-images branch 3 times, most recently from 5a05c8c to 30d7eb2 Compare October 18, 2023 07:07
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-937198-use-new-images branch 14 times, most recently from 5ad8306 to 13574c9 Compare October 31, 2023 10:08
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-937198-use-new-images branch 7 times, most recently from 2b0223e to 52e0cad Compare November 7, 2023 11:05
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review November 8, 2023 06:47
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner November 8, 2023 06:47
sfc-gh-pmotacki
sfc-gh-pmotacki reviewed Nov 8, 2023
View reviewed changes
.github/workflows/build-test.yml Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ConnectionWithOCSPModeIT.java Show resolved Hide resolved
pom.xml Show resolved Hide resolved
FIPS/pom.xml Show resolved Hide resolved
sfc-gh-igarish
sfc-gh-igarish approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure performance is good with JDK17. Server side halt the effort because they found perf issue between JDK11 and JDK17. Are we till compiling using JDK11 or moving to JDK17? If it's later, please do some perf test to compare JDK11 and JDK17.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-937198-use-new-images branch from 52e0cad to 54fd1f4 Compare November 14, 2023 06:25
@sfc-gh-pfus
Copy link
Contributor Author

Hi @sfc-gh-igarish . I created a task for performance tracking: https://snowflakecomputing.atlassian.net/browse/SNOW-969704
As for now we still compile with Java 8.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-937198-use-new-images branch from 54fd1f4 to 7b4e7e4 Compare November 14, 2023 06:34
@sonarqubemergegate SonarQubeMergeGate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-937198-use-new-images branch from 7b4e7e4 to 35903e4 Compare November 15, 2023 06:37
@sfc-gh-pfus sfc-gh-pfus merged commit 4625079 into master Nov 15, 2023
26 of 28 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-937198-use-new-images branch November 15, 2023 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki left review comments

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-pmotacki