Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-933005 Fix Wrong Error Code Issues in testProdConnectivity and testInsecureMode #1526

Merged
merged 3 commits into from
Oct 9, 2023
Merged

SNOW-933005 Fix Wrong Error Code Issues in testProdConnectivity and testInsecureMode #1526

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a52fcb
bad request error(390400) in connectionIT
sfc-gh-bli Oct 9, 2023
e8d20bc
fix testProdConnectivity
sfc-gh-bli Oct 9, 2023
5d88cdf
reformat
sfc-gh-bli Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/test/java/net/snowflake/client/jdbc/ConnectionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
package net.snowflake.client.jdbc;

import static net.snowflake.client.core.SessionUtil.CLIENT_SESSION_KEEP_ALIVE_HEARTBEAT_FREQUENCY;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.*;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.*;
import static org.junit.Assume.assumeTrue;
Expand Down Expand Up @@ -136,7 +135,7 @@ public void testProdConnectivity() throws SQLException {
DriverManager.getConnection(url, properties);
fail();
} catch (SQLException e) {
assertThat(e.getErrorCode(), is(INVALID_CONNECTION_INFO_CODE));
assertThat(e.getErrorCode(), anyOf(is(INVALID_CONNECTION_INFO_CODE), is(BAD_REQUEST_GS_CODE)));
}
}
}
Expand Down Expand Up @@ -545,7 +544,7 @@ public void testInsecureMode() throws SQLException {
DriverManager.getConnection(deploymentUrl, properties);
fail();
} catch (SQLException e) {
assertThat(e.getErrorCode(), is(INVALID_CONNECTION_INFO_CODE));
assertThat(e.getErrorCode(), anyOf(is(INVALID_CONNECTION_INFO_CODE), is(BAD_REQUEST_GS_CODE)));
}

deploymentUrl = "jdbc:snowflake://sfcsupport.snowflakecomputing.com?insecureMode=true";
Expand All @@ -559,7 +558,7 @@ public void testInsecureMode() throws SQLException {
DriverManager.getConnection(deploymentUrl, properties);
fail();
} catch (SQLException e) {
assertThat(e.getErrorCode(), is(INVALID_CONNECTION_INFO_CODE));
assertThat(e.getErrorCode(), anyOf(is(INVALID_CONNECTION_INFO_CODE), is(BAD_REQUEST_GS_CODE)));
}
}

Expand Down