Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-877275 : Build the console login url #1518

Merged
merged 6 commits into from
Dec 7, 2023
Merged

SNOW-877275 : Build the console login url #1518

merged 6 commits into from
Dec 7, 2023

Conversation

sfc-gh-igarish
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish commented Sep 30, 2023 •
edited
Loading

Overview

SNOW-877275

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-igarish sfc-gh-igarish requested a review from a team as a code owner September 30, 2023 01:02
@sfc-gh-igarish
Copy link
Collaborator Author

We need check with DB Sec team about: "I have some questions regarding ClientAuthnDTO needs to pass to console login or not. This we are doing for getting SSO and it useful on server side for telemetry like CLIENT_APP_ID and CLIENT_APP_VERSION."

@sfc-gh-igarish sfc-gh-igarish changed the title SNOW-869916 : Build the console login url SNOW-877275 : Build the console login url Oct 2, 2023
sfc-gh-skumbham
sfc-gh-skumbham approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-skumbham sfc-gh-skumbham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-stan sfc-gh-stan mentioned this pull request Oct 10, 2023
Merged
8 tasks
@sfc-gh-igarish sfc-gh-igarish force-pushed the igarish-SNOW-869916-multiple-SAML branch from fcdb8d9 to f40706e Compare October 21, 2023 01:55
@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-igarish sfc-gh-igarish merged commit 742c2f1 into master Dec 7, 2023
26 of 28 checks passed
@sfc-gh-igarish sfc-gh-igarish deleted the igarish-SNOW-869916-multiple-SAML branch December 7, 2023 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-skumbham sfc-gh-skumbham sfc-gh-skumbham approved these changes

@sfc-gh-mraja sfc-gh-mraja Awaiting requested review from sfc-gh-mraja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-igarish @sfc-gh-skumbham @sfc-gh-dprzybysz