Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-913746 Honor useS3RegionalUrl from JsonNode in getStageInfo #1514

Merged
merged 2 commits into from
Sep 22, 2023
Merged

SNOW-913746 Honor useS3RegionalUrl from JsonNode in getStageInfo #1514

merged 2 commits into from
Sep 22, 2023

Conversation

sfc-gh-japatel
Copy link
Collaborator

Overview

SNOW-913746

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  2. Please describe how your code solves the related issue.

    Currently, uploadWithoutConnection creates a Storage Client and uses StageInfo object. For Snowpipe Streaming, we need to enable useS3RegionalURL which doesn't use session instance. getStageInfo is the used by uploadWithoutConnection from JsonNode and doesn't check for useS3RegionalURL which will be passed from Server Side in client/configure API. Please keep an eye on Server side PR where I make changes in the response from ConfigureClientResponse

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-japatel sfc-gh-japatel requested a review from a team as a code owner September 19, 2023 22:31
sfc-gh-igarish
sfc-gh-igarish approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-japatel sfc-gh-japatel enabled auto-merge (squash) September 22, 2023 15:47
@sfc-gh-japatel sfc-gh-japatel merged commit 14c1318 into master Sep 22, 2023
12 checks passed
@sfc-gh-japatel sfc-gh-japatel deleted the japatel-SNOW-913746-stageinfo-useregionalurls3 branch September 22, 2023 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi Awaiting requested review from sfc-gh-hchaturvedi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-japatel @sfc-gh-igarish