Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Github issue 629 (SNOW-902727) #1513

Merged
merged 4 commits into from
Mar 6, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove logging password
  • Loading branch information
sfc-gh-pbulawa committed Mar 5, 2024
commit 19980e53323d66b23813faca6907b82940fe24db
25 changes: 16 additions & 9 deletions src/main/java/net/snowflake/client/core/SFBaseSession.java
Original file line number Diff line number Diff line change
@@ -392,31 +392,38 @@ public HttpClientSettingsKey getHttpClientKey() throws SnowflakeSQLException {
boolean httpUseProxy = Boolean.parseBoolean(systemGetProperty("http.useProxy"));
String httpProxyHost = systemGetProperty("http.proxyHost");
String httpProxyPort = systemGetProperty("http.proxyPort");
String httpProxyUser = (systemGetProperty("http.proxyUser") != null) ? systemGetProperty("http.proxyUser") : "";
String httpProxyPassword = (systemGetProperty("http.proxyPassword") != null) ? systemGetProperty("http.proxyPassword") : "";
String httpProxyUser =
(systemGetProperty("http.proxyUser") != null) ? systemGetProperty("http.proxyUser") : "";
String httpProxyPassword =
(systemGetProperty("http.proxyPassword") != null)
? systemGetProperty("http.proxyPassword")
: "";
String httpsProxyHost = systemGetProperty("https.proxyHost");
String httpsProxyPort = systemGetProperty("https.proxyPort");
String httpsProxyUser = (systemGetProperty("https.proxyUser") != null) ? systemGetProperty("https.proxyUser") : "";
String httpsProxyPassword = (systemGetProperty("https.proxyPassword") != null) ? systemGetProperty("https.proxyPassword") : "";
String httpsProxyUser =
(systemGetProperty("https.proxyUser") != null)
? systemGetProperty("https.proxyUser")
: "";
String httpsProxyPassword =
(systemGetProperty("https.proxyPassword") != null)
sfc-gh-dprzybysz marked this conversation as resolved.
Show resolved Hide resolved
? systemGetProperty("https.proxyPassword")
: "";
String httpProxyProtocol = systemGetProperty("http.proxyProtocol");
String noProxy = systemGetEnv("NO_PROXY");
String nonProxyHosts = systemGetProperty("http.nonProxyHosts");
// log the JVM parameters that are being used
if (httpUseProxy) {
logger.debug(
"http.useProxy={}, http.proxyHost={}, http.proxyPort={}, http.proxyUser={},"
+ "http.proxyPassword={}, https.proxyHost={}, https.proxyPort={}, "
+ "https.proxyUser={}, https.proxyPassword={}, http.nonProxyHosts={},"
"Proxy environment settings: http.useProxy={}, http.proxyHost={}, http.proxyPort={}, http.proxyUser={}, "
+ "https.proxyHost={}, https.proxyPort={}, https.proxyUser={}, http.nonProxyHosts={}, "
+ "NO_PROXY={}, http.proxyProtocol={}",
httpUseProxy,
httpProxyHost,
httpProxyPort,
httpProxyUser,
httpProxyPassword,
httpsProxyHost,
httpsProxyPort,
httpsProxyUser,
httpsProxyPassword,
nonProxyHosts,
noProxy,
httpProxyProtocol,
Loading