Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #1503
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-905110: META-INF/versions entires are not relocated #1503
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
sortPlugins
from thesortpom-maven-plugin
configuration.maven-antrun-plugin
is applied aftermaven-shade-plugin
.move
elements in themaven-antrun-plugin
configuration.Here's a screenshot comparing the JAR produced on
master
to the one produced on this branch. Notice that theMETA-INF/versions
classes are once again correctly relocated.Pre-review checklist