Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix META-INF/versions relocation #1504

Closed
wants to merge 1 commit into from

Conversation

pkoenig10
Copy link

@pkoenig10 pkoenig10 commented Aug 31, 2023

Overview

Fixes #1503

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-905110: META-INF/versions entires are not relocated  #1503

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    • Removes the sortPlugins from the sortpom-maven-plugin configuration.
    • Reorders the plugins so maven-antrun-plugin is applied after maven-shade-plugin.
    • Brings back the move elements in the maven-antrun-plugin configuration.

    Here's a screenshot comparing the JAR produced on master to the one produced on this branch. Notice that the META-INF/versions classes are once again correctly relocated.

Screenshot 2023-08-31 at 12 48 30 PM

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@pkoenig10 pkoenig10 requested a review from a team as a code owner August 31, 2023 20:00
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pkoenig10
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@ash211
Copy link
Contributor

ash211 commented Aug 31, 2023

@sfc-gh-igarish are you the right person to review?

@pkoenig10
Copy link
Author

Fixed in #1621

@pkoenig10 pkoenig10 closed this Feb 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-905110: META-INF/versions entires are not relocated
2 participants