Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test PR for Buffer API regression #1402

Closed
wants to merge 1 commit into from
Closed

Test PR for Buffer API regression #1402

wants to merge 1 commit into from

Conversation

sfc-gh-ext-simba-lb
Copy link
Contributor

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb commented May 26, 2023 •
edited
Loading

Overview

To test the regression that was fixed in PR 1401

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb force-pushed the integrationTestForSNOW-802910Fix branch 2 times, most recently from c5872ea to c38ef52 Compare May 29, 2023 20:40
@sfc-gh-ext-simba-lb
add integration test for ascii char issue fix
49a0f2e 
testing

remove unit test

format
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb force-pushed the integrationTestForSNOW-802910Fix branch from c38ef52 to 49a0f2e Compare May 29, 2023 20:47
@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb changed the title testing Test PR for Buffer API regression May 31, 2023
@ghost
Copy link

ghost commented Oct 12, 2023 •
edited by ghost
Loading

Close as this is for testing PR #1401 and that one is merged already.

@ghost ghost closed this Oct 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the integrationTestForSNOW-802910Fix branch October 31, 2024 11:30
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-ext-simba-lb