-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide QueryStatus V2 API #1371
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,7 +153,7 @@ public void addQueryToActiveQueryList(String queryID) { | |
* @return enum of type QueryStatus indicating the query's status | ||
* @throws SQLException | ||
*/ | ||
public QueryStatus getQueryStatus(String queryID) throws SQLException { | ||
public JsonNode getQueryMetadata(String queryID) throws SQLException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need this as public? |
||
// create the URL to check the query monitoring endpoint | ||
String statusUrl = ""; | ||
String sessionUrl = getUrl(); | ||
|
@@ -228,7 +228,16 @@ else if (ex instanceof SFException) { | |
} | ||
} | ||
} while (sessionRenewed); | ||
JsonNode queryNode = jsonNode.path("data").path("queries"); | ||
return jsonNode.path("data").path("queries"); | ||
} | ||
|
||
/** | ||
* @param queryID query ID of the query whose status is being investigated | ||
* @return enum of type QueryStatus indicating the query's status | ||
* @throws SQLException | ||
*/ | ||
public QueryStatus getQueryStatus(String queryID) throws SQLException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Definitely worth some deprecation comment now. |
||
JsonNode queryNode = getQueryMetadata(queryID); | ||
String queryStatus = ""; | ||
String errorMessage = ""; | ||
int errorCode = 0; | ||
|
@@ -267,6 +276,39 @@ else if (isAnError(result)) { | |
return result; | ||
} | ||
|
||
/** | ||
* @param queryID query ID of the query whose status is being investigated | ||
* @return a QueryStatusV2 instance indicating the query's status | ||
* @throws SQLException | ||
*/ | ||
public QueryStatusV2 getQueryStatusV2(String queryID) throws SQLException { | ||
JsonNode queryNode = getQueryMetadata(queryID); | ||
logger.debug("Query status: {}", queryNode.asText()); | ||
if (queryNode.isEmpty()) { | ||
return QueryStatusV2.empty(); | ||
} | ||
JsonNode node = queryNode.get(0); | ||
long endTime = node.path("endTime").asLong(0); | ||
int errorCode = node.path("errorCode").asInt(0); | ||
String errorMessage = node.path("errorMessage").asText("No error reported"); | ||
String id = node.path("id").asText(""); | ||
String name = node.path("status").asText(""); | ||
long sessionId = node.path("sessionId").asLong(0); | ||
String sqlText = node.path("sqlText").asText(""); | ||
long startTime = node.path("startTime").asLong(0); | ||
String state = node.path("state").asText(""); | ||
int totalDuration = node.path("totalDuration").asInt(0); | ||
String warehouseExternalSize = node.path("warehouseExternalSize").asText(null); | ||
int warehouseId = node.path("warehouseId").asInt(0); | ||
String warehouseName = node.path("warehouseName").asText(null); | ||
String warehouseServerType = node.path("warehouseServerType").asText(null); | ||
QueryStatusV2 result = new QueryStatusV2(endTime, errorCode, errorMessage, id, name, sessionId, sqlText, startTime, state, totalDuration, warehouseExternalSize, warehouseId, warehouseName, warehouseServerType); | ||
if (!result.isStillRunning()) { | ||
activeAsyncQueries.remove(queryID); | ||
} | ||
return result; | ||
} | ||
|
||
/** | ||
* Add a property If a property is known for connection, add it to connection properties If not, | ||
* add it as a dynamic session parameters | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
package net.snowflake.client.jdbc; | ||
|
||
import net.snowflake.client.core.QueryStatus; | ||
|
||
public final class QueryStatusV2 { | ||
private final long endTime; | ||
sfc-gh-pfus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
private final int errorCode; | ||
private final String errorMessage; | ||
private final String id; | ||
private final String name; | ||
private final long sessionId; | ||
private final String sqlText; | ||
private final long startTime; | ||
private final String state; | ||
private final QueryStatus status; | ||
private final int totalDuration; | ||
private final String warehouseExternalSize; | ||
private final int warehouseId; | ||
private final String warehouseName; | ||
private final String warehouseServerType; | ||
|
||
public QueryStatusV2( | ||
long endTime, | ||
int errorCode, | ||
String errorMessage, | ||
String id, | ||
String name, | ||
long sessionId, | ||
String sqlText, | ||
long startTime, | ||
String state, | ||
int totalDuration, | ||
String warehouseExternalSize, | ||
int warehouseId, | ||
String warehouseName, | ||
String warehouseServerType) { | ||
this.endTime = endTime; | ||
this.errorCode = errorCode; | ||
this.errorMessage = errorMessage; | ||
this.id = id; | ||
this.name = name; | ||
this.sessionId = sessionId; | ||
this.sqlText = sqlText; | ||
this.startTime = startTime; | ||
this.state = state; | ||
this.status = QueryStatus.getStatusFromString(name); | ||
this.totalDuration = totalDuration; | ||
this.warehouseExternalSize = warehouseExternalSize; | ||
this.warehouseId = warehouseId; | ||
this.warehouseName = warehouseName; | ||
this.warehouseServerType = warehouseServerType; | ||
} | ||
|
||
public static QueryStatusV2 empty() { | ||
return new QueryStatusV2(0, 0, "", "", "", 0, "", 0, "", 0, "", 0, "", ""); | ||
} | ||
|
||
public boolean isEmpty() { | ||
return name.isEmpty(); | ||
} | ||
|
||
public boolean isStillRunning() { | ||
return QueryStatus.isStillRunning(status); | ||
} | ||
|
||
public boolean isSuccess() { | ||
return status == QueryStatus.SUCCESS; | ||
} | ||
|
||
public boolean isAnError() { | ||
return QueryStatus.isAnError(status); | ||
} | ||
|
||
public long getEndTime() { | ||
return endTime; | ||
} | ||
|
||
public int getErrorCode() { | ||
return errorCode; | ||
} | ||
|
||
public String getErrorMessage() { | ||
return errorMessage; | ||
} | ||
|
||
public String getId() { | ||
return id; | ||
} | ||
|
||
public String getName() { | ||
return name; | ||
} | ||
|
||
public long getSessionId() { | ||
return sessionId; | ||
} | ||
|
||
public String getSqlText() { | ||
return sqlText; | ||
} | ||
|
||
public long getStartTime() { | ||
return startTime; | ||
} | ||
|
||
public String getState() { | ||
return state; | ||
} | ||
|
||
public int getTotalDuration() { | ||
return totalDuration; | ||
} | ||
|
||
public String getWarehouseExternalSize() { | ||
return warehouseExternalSize; | ||
} | ||
|
||
public int getWarehouseId() { | ||
return warehouseId; | ||
} | ||
|
||
public String getWarehouseName() { | ||
return warehouseName; | ||
} | ||
|
||
public String getWarehouseServerType() { | ||
return warehouseServerType; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,8 @@ | |
|
||
import java.sql.SQLException; | ||
import java.util.List; | ||
|
||
import com.fasterxml.jackson.databind.JsonNode; | ||
import net.snowflake.client.core.QueryStatus; | ||
|
||
/** This interface defines Snowflake specific APIs for ResultSet */ | ||
|
@@ -35,6 +37,19 @@ public interface SnowflakeResultSet { | |
*/ | ||
String getQueryErrorMessage() throws SQLException; | ||
|
||
/** | ||
* This function retrieves the status of an asynchronous query. An empty ResultSet object has | ||
* already been returned, but the query may still be running. This function can be used to query | ||
* whether it is possible to retrieve results from the ResultSet already. | ||
* <p> | ||
* <code>status.isSuccess()</code> means that results can be retrieved. | ||
* </p> | ||
* | ||
* @return an instance containing query metadata | ||
* @throws SQLException | ||
*/ | ||
QueryStatusV2 getQueryStatus() throws SQLException; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm wondering if we should name it consistently to existing function - There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also why new function is not taking queryId as an argument? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because this is a function on resultSet - resultSet knows its queryId (even provides it by getQueryId). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is more about async execution. Are we providing resultset object before completed the query? |
||
|
||
/** | ||
* Get a list of ResultSetSerializables for the ResultSet in order to parallel processing | ||
* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This information is not accurate anymore?