Skip to content

Commit

Permalink
code review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-ext-simba-jf committed Nov 6, 2024
1 parent 284806e commit 5e99b2c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ private static QueryContextElement deserializeQueryContextElementDTO(
* Serialize the QueryContext cache to a QueryContextDTO object, which can be serialized to JSON
* automatically later.
*
* @return QueryContextDTO {@link QueryContextDTO}
* @return {@link QueryContextDTO}
*/
public QueryContextDTO serializeQueryContextDTO() {
synchronized (this) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/snowflake/client/core/ResultUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public static Object effectiveParamValue(Map<String, Object> parameters, String
* @param id id
* @param param timestamp output format param
* @param defaultFormat default format
* @return SnowflakeDateTimeFormat {@link SnowflakeDateTimeFormat}
* @return {@link SnowflakeDateTimeFormat}
*/
public static SnowflakeDateTimeFormat specializedFormatter(
Map<String, Object> parameters, String id, String param, String defaultFormat) {
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/net/snowflake/client/core/SFBaseSession.java
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ public void setInjectFileUploadFailure(String fileToFail) {
*
* @see <a
* href="https://docs.snowflake.com/en/sql-reference/parameters#client-timestamp-type-mapping">CLIENT_TIMESTAMP_TYPE_MAPPING</a>
* @return SnowflakeType {@link SnowflakeType}
* @return {@link SnowflakeType}
*/
public SnowflakeType getTimestampMappedType() {
return timestampMappedType;
Expand Down Expand Up @@ -709,7 +709,7 @@ public void unsetInvalidProxyHostAndPort() {
/**
* Get OCSP mode
*
* @return OCSPMode {@link OCSPMode}
* @return {@link OCSPMode}
*/
public OCSPMode getOCSPMode() {
OCSPMode ret;
Expand Down Expand Up @@ -812,7 +812,7 @@ public void setMetadataRequestUseConnectionCtx(boolean enabled) {
/**
* Get injected delay
*
* @return AtomicInteger {@link AtomicInteger}
* @return {@link AtomicInteger}
*/
AtomicInteger getInjectedDelay() {
return _injectedDelay;
Expand Down Expand Up @@ -1260,7 +1260,7 @@ public void clearSqlWarnings() {
/**
* Get the SFConnectionHandler
*
* @return SFConnectionHandler {@link SFConnectionHandler}
* @return {@link SFConnectionHandler}
*/
public SFConnectionHandler getSfConnectionHandler() {
return sfConnectionHandler;
Expand All @@ -1284,7 +1284,7 @@ public SFConnectionHandler getSfConnectionHandler() {
public abstract int getMaxHttpRetries();

/**
* @return SnowflakeConnectString {@link SnowflakeConnectString}
* @return {@link SnowflakeConnectString}
*/
public abstract SnowflakeConnectString getSnowflakeConnectionString();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public static boolean isFileTransfer(String sql) {
* Retrieves the current result as a ResultSet, if any. This is invoked by SnowflakeStatement and
* should return an SFBaseResultSet, which is then wrapped in a SnowflakeResultSet.
*
* @return SFBaseResultSet {@link SFBaseResultSet}
* @return {@link SFBaseResultSet}
*/
public abstract SFBaseResultSet getResultSet();

Expand Down

0 comments on commit 5e99b2c

Please sign in to comment.