CR suggestions

snowflakedb · Mar 21, 2024 · 5d0ed00 · 5d0ed00
1 parent a90eb2e
commit 5d0ed00
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/main/java/net/snowflake/client/jdbc/SnowflakeType.java b/src/main/java/net/snowflake/client/jdbc/SnowflakeType.java
@@ -53,7 +53,7 @@ public static SnowflakeType fromString(String name) {
   }
 
   public static JavaDataType getJavaType(SnowflakeType type) {
-    // TODO structuredType fill for Array and Map
+    // TODO structuredType fill for Array and Map: SNOW-1234216, SNOW-1234214
     switch (type) {
       case TEXT:
         return JavaDataType.JAVA_STRING;

diff --git a/src/test/java/net/snowflake/client/AbstractDriverIT.java b/src/test/java/net/snowflake/client/AbstractDriverIT.java
@@ -323,6 +323,7 @@ public static Connection getConnection(
     properties.put("ssl", params.get("ssl"));
 
     properties.put("internal", Boolean.TRUE.toString()); // TODO: do we need this?
+    properties.put("insecureMode", false); // use OCSP for all tests.
 
     if (injectSocketTimeout > 0) {
       properties.put("injectSocketTimeout", String.valueOf(injectSocketTimeout));

diff --git a/src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java b/src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java
@@ -24,6 +24,7 @@
 import net.snowflake.client.RunningOnGithubAction;
 import net.snowflake.client.ThrowingConsumer;
 import net.snowflake.client.category.TestCategoryStructuredType;
+import net.snowflake.client.core.SnowflakeJdbcInternalApi;
 import net.snowflake.client.core.structs.SnowflakeObjectTypeFactories;
 import org.junit.Assume;
 import org.junit.Before;
@@ -438,6 +439,7 @@ private void withFirstRow(String sqlText, ThrowingConsumer<ResultSet, SQLExcepti
     }
   }
 
+  @SnowflakeJdbcInternalApi
   enum ResultSetFormatType {
     JSON("JSON"),
     ARROW_WITH_JSON_STRUCTURED_TYPES("ARROW"),