Use role SYSADMIN for testing #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-alhuang
requested review from
sfc-gh-tzhang and
a team
as code owners
sfc-gh-alhuang
force-pushed
the
alhuang-merge-gate-sysadmin
branch
from
14dd301 to
8a78bd3
Compare
| @@ -302,6 +302,7 @@ public static Connection getConnection(boolean isStreamingConnection) throws Exc | |||
| props.put("warehouse", warehouse); | |||
| props.put("client_session_keep_alive", "true"); | |||
| props.put("privateKey", privateKey); | |||
| props.put("role", role); | |||
|
|
|||
There was a problem hiding this comment.
i'm guessing you've updated the role in the files to be SYSADMIN too..
Did that not require any special permissions in any environment, for instance to grant usage on EXT VOL to role SYSADMIN?
There was a problem hiding this comment.
Yes I've grantde permission on those sfctest0 accounts.
sfc-gh-hmadan
approved these changes
Nov 15, 2024
sfc-gh-xhuang
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original testing profile use ACCOUNTADMIN, change it to SYSADMIN.