Schema evolution test for Iceberg ingestion #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/java/net/snowflake/ingest/streaming/internal/datatypes/AbstractDataTypeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/ingest/streaming/internal/datatypes/AbstractDataTypeTest.java
Outdated
Show resolved
Hide resolved
| import org.junit.runners.Parameterized; | ||
|
|
||
| public class IcebergSchemaEvolutionIT extends AbstractDataTypeTest { | ||
| @Parameterized.Parameters(name = "compressionAlgorithm={0}, icebergSerializationPolicy={1}") |
There was a problem hiding this comment.
nit: why does compression algorithm need to be a test parameter?
src/test/java/net/snowflake/ingest/streaming/internal/it/IcebergSchemaEvolutionIT.java
Show resolved
Hide resolved
src/test/java/net/snowflake/ingest/streaming/internal/it/IcebergSchemaEvolutionIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/ingest/streaming/internal/it/IcebergSchemaEvolutionIT.java
Outdated
Show resolved
Hide resolved
sfc-gh-hmadan
approved these changes
Nov 5, 2024
sfc-gh-alhuang
force-pushed
the
alhuang-schema-evolution-IT
branch
from
527e7d9 to
c939dc2
Compare
sfc-gh-alhuang
force-pushed
the
alhuang-schema-evolution-IT
branch
from
c939dc2 to
5dcfd48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a schema evolution test for Iceberg ingestion. Will add one for structured data type after #869 is merge as that PR includes logic for object comparison.