Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1760732 Enable Iceberg mode from properties #871

Merged
merged 7 commits into from
Oct 29, 2024
Merged

SNOW-1760732 Enable Iceberg mode from properties #871

merged 7 commits into from
Oct 29, 2024

Conversation

sfc-gh-alhuang
Copy link
Contributor

@sfc-gh-alhuang sfc-gh-alhuang commented Oct 23, 2024 •
edited
Loading

The PR includes following changes:

  1. Remove setIceberg from StreamingIngestClientFactory, set Iceberg mode from properties.
  2. Renamed isIceberg to enableIcebergStreaming.

@sfc-gh-alhuang sfc-gh-alhuang requested review from sfc-gh-tzhang and a team as code owners October 23, 2024 23:12
@sfc-gh-alhuang sfc-gh-alhuang force-pushed the alhuang-zstd branch 3 times, most recently from fe0409b to 61656f0 Compare October 25, 2024 21:25
@sfc-gh-alhuang sfc-gh-alhuang force-pushed the alhuang-zstd branch 2 times, most recently from d565b4b to 0eb347a Compare October 28, 2024 20:15
sfc-gh-hmadan
sfc-gh-hmadan reviewed Oct 28, 2024
View reviewed changes
src/main/java/net/snowflake/ingest/utils/ParameterProvider.java Outdated
@@ -152,6 +142,14 @@ private void setParameterMap(
BUFFER_FLUSH_INTERVAL_IN_MILLIS, MAX_CLIENT_LAG));
}

/* STREAMING_ICEBERG should be the first thing to set as it affects other parameters */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ENABLE_ICEBERG_STREAMING should be ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified

@sfc-gh-alhuang sfc-gh-alhuang enabled auto-merge (squash) October 28, 2024 22:33
@sfc-gh-alhuang sfc-gh-alhuang merged commit 59b686d into master Oct 29, 2024
47 checks passed
@sfc-gh-alhuang sfc-gh-alhuang deleted the alhuang-zstd branch October 29, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-hmadan sfc-gh-hmadan sfc-gh-hmadan approved these changes

@sfc-gh-tzhang sfc-gh-tzhang Awaiting requested review from sfc-gh-tzhang sfc-gh-tzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-alhuang @sfc-gh-hmadan