Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1754295 - Prep for upcoming subscoped tokens PR #867

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

sfc-gh-hmadan
Copy link
Collaborator

  1. Rename ExternalVolumeManager --> PresignedUrlExternalVolumeManager
  2. Rename ExternalVolume --> PresignedUrlExternalVolume
  3. Change BlobPath field names from filename/url (which were still pretty ambiguous) to fileRegistrationPath / uploadPath.

This PR does not introduce any logical changes, and is preparing the brach for the next (stacked) PR that actually brings in a subscoped token based external volume manager.

@sfc-gh-hmadan sfc-gh-hmadan requested review from sfc-gh-tzhang and a team as code owners October 21, 2024 06:37
Copy link
Contributor

@sfc-gh-alhuang sfc-gh-alhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sfc-gh-hmadan sfc-gh-hmadan merged commit 513b589 into master Oct 21, 2024
47 checks passed
@sfc-gh-hmadan sfc-gh-hmadan deleted the hmadan-subscoped-1 branch October 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants