Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Stacked PR) Code review changes for Parquet V2 #862

Merged
merged 1 commit into from
Oct 12, 2024
Merged

(Stacked PR) Code review changes for Parquet V2 #862

merged 1 commit into from
Oct 12, 2024

Conversation

sfc-gh-hmadan
Copy link
Collaborator

Took the liberty of sending out a PR instead of describing what I had in mind textually.

  1. Remove logic from OpenChannelResponse contract class
  2. Move writerVersion defaulting to channel construction callsite in clientInternal (from channel ctor), instead of passing writerVersion=null into the channel.
  3. Pass around writerVersion via RowBuffer into Flusher, instead of via the per-chunk flushContext.
  4. Remove a test-only overload of ChannelInternal
  5. Remove an unnecessary parameter on ChannelInternal ctor (bdecVersion)
  6. Remove SerializationPolicy.NON_ICEBERG, remove the custom SerPolicy.fromName method and use Enum.valueOf that java already has

Once the merge gates are green, will merge this into the V2 PR.

@sfc-gh-hmadan sfc-gh-hmadan requested review from sfc-gh-tzhang and a team as code owners October 12, 2024 03:02
@sfc-gh-hmadan sfc-gh-hmadan merged commit 7356bee into alhuang/parquetV2 Oct 12, 2024
44 checks passed
@sfc-gh-hmadan sfc-gh-hmadan deleted the alhuang-parquetV2-codereview branch October 12, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-alhuang sfc-gh-alhuang Awaiting requested review from sfc-gh-alhuang

@sfc-gh-tzhang sfc-gh-tzhang Awaiting requested review from sfc-gh-tzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-hmadan