Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-SNOW Remove unnecessary dependencies to reduce jar size #852

Merged
merged 1 commit into from
Oct 3, 2024
Merged

NO-SNOW Remove unnecessary dependencies to reduce jar size #852

merged 1 commit into from
Oct 3, 2024
+8 −8

Conversation

sfc-gh-japatel
Copy link
Collaborator

we are not using netty except the netty common, so remove all that I added in for license.

@sfc-gh-japatel sfc-gh-japatel requested review from sfc-gh-tzhang and a team as code owners October 3, 2024 18:03
sfc-gh-tzhang
sfc-gh-tzhang approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now, thanks!

@sfc-gh-japatel sfc-gh-japatel merged commit 4dcd4a6 into master Oct 3, 2024
45 checks passed
@sfc-gh-japatel sfc-gh-japatel deleted the japatel-no-snow-hadoop-cleanup branch October 3, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-xhuang sfc-gh-xhuang sfc-gh-xhuang approved these changes

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-japatel @sfc-gh-tzhang @sfc-gh-xhuang