SNOW-1707031 hadoop upgrade for vulnerability fix #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-japatel
changed the title
sfc-gh-japatel
changed the title
sfc-gh-xhuang
changed the title
sfc-gh-xhuang
approved these changes
Oct 2, 2024
sfc-gh-tzhang
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
LGTM, @sfc-gh-lsembera do we need to check with security about the added license?
I dont think so, it's existing license we are adding and it's a known one. |
|
Thanks, @sfc-gh-japatel. The only issue I see here is that it will further inflate the JAR size. Should we try to exclude the new dependencies and see whether tests pass? I don't see why would the SDK need Netty. |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-ORGAPACHEHADOOP-8089372
sfc-gh-xhuang
force-pushed
the
japatel-hadoop
branch
from
54d857e to
8ab3e42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1707031
Added few exclusions. Here is how I did it: I looked at the failed command of
mvn clean installand compared it withmvn dependency:treeMostly it's about finding which dependencies can be excluded so that the new upgrade which brought in new dependencies are used.
Other minor fixes for merge gates to pass. Ran locally and it succeeeded