Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add chunk offset to file id key to make each chunk have a uni… #848

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Revert "Add chunk offset to file id key to make each chunk have a uni… #848

merged 1 commit into from
Oct 1, 2024

Conversation

sfc-gh-psaha
Copy link
Contributor

…que key (#825)" temporarily to exclude it from the next release.

This reverts commit a107b50.

@sfc-gh-psaha sfc-gh-psaha requested review from sfc-gh-tzhang and a team as code owners October 1, 2024 16:08
sfc-gh-tzhang
sfc-gh-tzhang approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to rollback, the release can be on a different branch, but I'm also fine with rolling it back, less work for the triage :)

@sfc-gh-psaha sfc-gh-psaha enabled auto-merge (squash) October 1, 2024 17:04
sfc-gh-xhuang
sfc-gh-xhuang requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-xhuang sfc-gh-xhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming revert

@sfc-gh-psaha sfc-gh-psaha merged commit 0930648 into master Oct 1, 2024
47 checks passed
@sfc-gh-psaha sfc-gh-psaha deleted the psaha-SNOW-1660058-add-chunk-index branch October 1, 2024 17:47
sfc-gh-psaha added a commit that referenced this pull request Oct 18, 2024
@sfc-gh-psaha
Revert "Revert "Add chunk offset to file id key to make each chunk ha…
165b395 
…ve a uni… (#848)"

This reverts commit 0930648.
@sfc-gh-psaha sfc-gh-psaha mentioned this pull request Oct 18, 2024
Merged
sfc-gh-psaha added a commit that referenced this pull request Oct 18, 2024
@sfc-gh-psaha
Revert "Revert "Add chunk offset to file id key to make each chunk ha…
3a2ab2b 
…ve a uni… (#848)"

This reverts commit 0930648.
sfc-gh-psaha added a commit that referenced this pull request Oct 30, 2024
@sfc-gh-psaha
Revert "Revert "Add chunk offset to file id key to make each chunk ha…
6707e0d 
…ve a uni… (#848)"

This reverts commit 0930648.
sfc-gh-psaha added a commit that referenced this pull request Oct 31, 2024
@sfc-gh-psaha
Revert "Revert "Add chunk offset to file id key to make each chunk ha…
f1262aa 
…ve a uni… (#848)"

This reverts commit 0930648.
sfc-gh-psaha added a commit that referenced this pull request Oct 31, 2024
@sfc-gh-psaha
Revert "Revert "Add chunk offset to file id key to make each chunk ha…
e1f2073 
…ve a uni… (#848)"

This reverts commit 0930648.
sfc-gh-psaha added a commit that referenced this pull request Oct 31, 2024
@sfc-gh-psaha
Revert "Revert "Add chunk offset to file id key to make each chunk ha…
17de48f 
…ve a uni… (#848)"

This reverts commit 0930648.
sfc-gh-psaha added a commit that referenced this pull request Oct 31, 2024
@sfc-gh-psaha
Re-merge "Add chunk offset to file id key to make each chunk have a u…
8cbf2da 
…nique key" from pull 825 (#865)

* Revert "Revert "Add chunk offset to file id key to make each chunk have a uni… (#848)"

This reverts commit 0930648.

* Comments from Hitesh

* Fix test to handle iceberg case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-xhuang sfc-gh-xhuang sfc-gh-xhuang approved these changes

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-psaha @sfc-gh-tzhang @sfc-gh-xhuang