Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.2.2 release with behavior change reverted #827

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

sfc-gh-tzhang
Copy link
Contributor

No description provided.

@sfc-gh-tzhang sfc-gh-tzhang requested review from a team as code owners September 12, 2024 19:24
@sfc-gh-xhuang sfc-gh-xhuang changed the title V2.2.2 release with behavior change reverted [DNM] V2.2.2 release with behavior change reverted Sep 12, 2024
@sfc-gh-hmadan
Copy link
Collaborator

Do we need a more "param protection" style development pattern in the SDK? So that we can tell customers how to disable a bad update by turning off an internal undocumented parameter after their upgrade?

Reverting is yet another behavior change for someone that starts using the new behavior, so am not sure if we can have code reverts as our primary strategy for behavior change management in the SDK.

@sfc-gh-tzhang sfc-gh-tzhang changed the title [DNM] V2.2.2 release with behavior change reverted V2.2.2 release with behavior change reverted Sep 12, 2024
@sfc-gh-tzhang sfc-gh-tzhang merged commit 579cbf3 into tzhang-si-release-2.2.2 Sep 12, 2024
44 checks passed
@sfc-gh-tzhang sfc-gh-tzhang deleted the tzhang-si-release branch September 12, 2024 21:01
@sfc-gh-tzhang
Copy link
Contributor Author

Do we need a more "param protection" style development pattern in the SDK? So that we can tell customers how to disable a bad update by turning off an internal undocumented parameter after their upgrade?

I think this makes sense in general, but we haven't have time to do it. And my concern of introducing parameters is the additional work of maintaining them, parameter drift, etc.

@sfc-gh-tzhang
Copy link
Contributor Author

Reverting is yet another behavior change for someone that starts using the new behavior, so am not sure if we can have code reverts as our primary strategy for behavior change management in the SDK.

This behavior change is not in any of the released SDK versions, we just want to release a patch version with the fix of the corruption you reported (again, thanks for catching it!) exclude this behavior change.

davidvigier added a commit to observeinc/snowflake-ingest-java that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants