Reject new stage metadata if the deployment id does not match what the client was created with #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tzhang
approved these changes
Jul 16, 2024
src/main/java/net/snowflake/ingest/streaming/internal/StreamingIngestStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/StreamingIngestStage.java
Show resolved
Hide resolved
| 0035=Failed to load {0}. If you use FIPS, import BouncyCastleFipsProvider in the application: {1} |
There was a problem hiding this comment.
@sfc-gh-alhuang FYI, let's make sure to update the error message as well when removing an error, or it might be a good idea to never reuse error codes as customer might have custom dependency on them :)
There was a problem hiding this comment.
+1 never remove previously used error codes - maybe just rename them if needed to indicate that they are not used anymore.
sfc-gh-psaha
force-pushed
the
psaha-SNOW-1511536-match-deployment
branch
from
c8c7a5a to
0ef0e29
Compare
…e client was created with
sfc-gh-psaha
force-pushed
the
psaha-SNOW-1511536-match-deployment
branch
from
0ef0e29 to
1e9e738
Compare
sfc-gh-psaha
force-pushed
the
psaha-SNOW-1511536-match-deployment
branch
from
1e9e738 to
ef07694
Compare
| 0035=Failed to load {0}. If you use FIPS, import BouncyCastleFipsProvider in the application: {1} | ||
| 0036=Failed to drop channel: {0} | ||
| 0037=Deployment ID mismatch, Client was created on: {0}, Got upload location for: {1}. Please restart client: {2}. |
There was a problem hiding this comment.
should this be please recreate client? (as there is no restart functionality)
There was a problem hiding this comment.
I meant it as "shut down your application and restart it".
sfc-gh-kgaputis
pushed a commit
to sfc-gh-kgaputis/snowflake-ingest-java
that referenced
this pull request
Sep 12, 2024
…e client was created with (snowflakedb#794) * Reject new stage metadata if the deployment id does not match what the client was created with * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents issues when there is transparent failover using Client Redirect or another similar mechanism. Along the way, I found some missing/misconfigured error message resource and fixed them.