Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW Fix flaky test using multiple threads #790

Merged
merged 1 commit into from
Jul 9, 2024
Merged

NO-SNOW Fix flaky test using multiple threads #790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/test/java/net/snowflake/ingest/streaming/internal/StreamingIngestBigFilesIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,16 @@ private void ingestRandomRowsToTable(
boolean isNullable)
throws ExecutionException, InterruptedException {

List<Map<String, Object>> rows = new ArrayList<>();
final List<Map<String, Object>> rows = Collections.synchronizedList(new ArrayList<>());
for (int i = 0; i < batchSize; i++) {
Random r = new Random();
rows.add(TestUtils.getRandomRow(r, isNullable));
}

ExecutorService testThreadPool = Executors.newFixedThreadPool(numChannels);
CompletableFuture[] futures = new CompletableFuture[numChannels];
List<SnowflakeStreamingIngestChannel> channelList = new ArrayList<>();
List<SnowflakeStreamingIngestChannel> channelList =
Collections.synchronizedList(new ArrayList<>());
for (int i = 0; i < numChannels; i++) {
final String channelName = "CHANNEL" + i;
int finalI = i;
Expand Down
Loading