Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1512935 Retry SocketTimeoutException #789

Merged
merged 2 commits into from
Jul 9, 2024
Merged

SNOW-1512935 Retry SocketTimeoutException #789

merged 2 commits into from
Jul 9, 2024

Conversation

sfc-gh-lsembera
Copy link
Contributor

This PR makes the SDK retry requests that fail with SocketTimeoutException.

@sfc-gh-lsembera sfc-gh-lsembera requested review from sfc-gh-tzhang and a team as code owners July 5, 2024 14:47
sfc-gh-tzhang
sfc-gh-tzhang approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just want to make sure we're not masking any potential bugs in the code by adding retries, thanks!

src/main/java/net/snowflake/ingest/utils/HttpUtil.java Show resolved Hide resolved
@sfc-gh-lsembera sfc-gh-lsembera merged commit 463e95a into master Jul 9, 2024
48 checks passed
@sfc-gh-lsembera sfc-gh-lsembera deleted the lsembera/retry branch July 9, 2024 14:25
sfc-gh-kgaputis pushed a commit to sfc-gh-kgaputis/snowflake-ingest-java that referenced this pull request Sep 12, 2024
@sfc-gh-lsembera @sfc-gh-kgaputis
SNOW-1512935 Retry SocketTimeoutException (snowflakedb#789)
c98252e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-lsembera @sfc-gh-tzhang