SNOW-1492090 Snowpipe streaming file master key id rotation #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ain/java/net/snowflake/ingest/streaming/internal/SnowflakeStreamingIngestClientInternal.java
Outdated
Show resolved
Hide resolved
...ain/java/net/snowflake/ingest/streaming/internal/SnowflakeStreamingIngestClientInternal.java
Outdated
Show resolved
Hide resolved
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
2 times, most recently
from
12d3fff to
4b00b0a
Compare
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
from
7c8f5ed to
7147d15
Compare
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
from
7147d15 to
77e4da5
Compare
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
from
42a23ca to
200034b
Compare
There was a problem hiding this comment.
Thanks, @sfc-gh-bmikaili , as we discuss IRL, let's keep the old code path around, and only trigger the new code path when the encryption keys array from the server is not-null.
src/main/java/net/snowflake/ingest/streaming/internal/BlobBuilder.java
Outdated
Show resolved
Hide resolved
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
from
f74b749 to
34968af
Compare
…pipe-streaming-file-master-key-id-rotation
…pipe-streaming-file-master-key-id-rotation
…pipe-streaming-file-master-key-id-rotation
|
@sfc-gh-bmikaili to resolve merge conflicts |
…90-snowpipe-streaming-file-master-key-id-rotation
…90-snowpipe-streaming-file-master-key-id-rotation
|
@sfc-gh-tzhang @sfc-gh-hmadan @sfc-gh-alhuang could you review this PR, please? |
This reverts commit 796fce1.
|
Long running tests succeeded, with one exception that failed due to flaky unrelated test. |
sfc-gh-alhuang
approved these changes
Nov 6, 2024
| } | ||
|
|
||
| public String getFullyQualifiedName() { | ||
| return String.format("%s.%s.%s", databaseName, schemaName, tableName); |
There was a problem hiding this comment.
Could be replace with Utils.getFullyQualifiedTableName(databaseName, schemaName, tableName).
| @@ -404,6 +409,17 @@ public SnowflakeStreamingIngestChannelInternal<?> openChannel(OpenChannelRequest | |||
| this.storageManager.registerTable( | |||
| new TableRef(response.getDBName(), response.getSchemaName(), response.getTableName())); | |||
|
|
|||
| // Add encryption key to the client map for the table | |||
| this.encryptionKeysPerTable.put( | |||
There was a problem hiding this comment.
This might not be necessary? getOrDefault with the same default value as here is called in BlobBuilder.java line 90.
There was a problem hiding this comment.
Good point, removed.
…90-snowpipe-streaming-file-master-key-id-rotation
sfc-gh-lsembera
deleted the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements encryption key refresh from the server. If the register blob endpoint responds with encryption keys as
null, the encryption key from the open channel response is used. If the register blob endpoint responds with non-empty list of encryption keys, these keys are used for encryption of subsequent BDEC files.