Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-snow Fix flaky test #772

Merged
merged 2 commits into from
Jun 14, 2024
Merged

no-snow Fix flaky test #772

merged 2 commits into from
Jun 14, 2024

Conversation

sfc-gh-lsembera
Copy link
Contributor

@sfc-gh-lsembera sfc-gh-lsembera commented Jun 12, 2024 •
edited
Loading

This PR fixes a flaky test, which is writing to ArrayList from multiple futures.

@sfc-gh-lsembera sfc-gh-lsembera marked this pull request as ready for review June 12, 2024 16:59
@sfc-gh-lsembera sfc-gh-lsembera requested review from sfc-gh-tzhang and a team as code owners June 12, 2024 16:59
sfc-gh-asen
sfc-gh-asen approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-asen sfc-gh-asen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-lsembera sfc-gh-lsembera merged commit 188632a into master Jun 14, 2024
48 checks passed
@sfc-gh-lsembera sfc-gh-lsembera deleted the lsembera/flaky-test branch June 14, 2024 12:15
sfc-gh-kgaputis pushed a commit to sfc-gh-kgaputis/snowflake-ingest-java that referenced this pull request Sep 12, 2024
@sfc-gh-lsembera @sfc-gh-kgaputis
no-snow Fix flaky test (snowflakedb#772)
8d89112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asen sfc-gh-asen sfc-gh-asen approved these changes

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-lsembera @sfc-gh-tzhang @sfc-gh-asen