Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-snow Parallelize e2e jar tests #767

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

sfc-gh-lsembera
Copy link
Contributor

@sfc-gh-lsembera sfc-gh-lsembera commented Jun 6, 2024

This PR parallelizes executions of e2e jar test across multiple GitHub Actions jobs. So far, test executions for shaded, unshaded and FIPS JARs with java 8, 11, 17 and 21 were all running in a single job. It is fine if the tests are quick, but before releases we additionally test long-running ingestion, which started timing out after 6 hours.

With this PR, we generate the build matrix of:

[AWS, GCP, Azure] x [Java 8, 11, 17, 21] x [shaded, unshaded, fips]

(in total 36 GitHub Action jobs)

@sfc-gh-lsembera sfc-gh-lsembera force-pushed the lsembera/long-running-test branch 7 times, most recently from 4bb90fe to 189013f Compare June 10, 2024 08:52
@sfc-gh-lsembera sfc-gh-lsembera changed the title Run long running test with JDBC driver 3.16.1 no-snow Parallelize e2e jar tests Jun 10, 2024
@sfc-gh-lsembera sfc-gh-lsembera marked this pull request as ready for review June 10, 2024 09:31
@sfc-gh-lsembera sfc-gh-lsembera requested review from sfc-gh-tzhang and a team as code owners June 10, 2024 09:31
Copy link
Collaborator

@sfc-gh-rcheng sfc-gh-rcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

Copy link
Contributor

@sfc-gh-asen sfc-gh-asen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, PTAL, otherwise LGTM, thanks!

e2e-jar-test/run_e2e_jar_test.sh Outdated Show resolved Hide resolved
e2e-jar-test/run_e2e_jar_test.sh Outdated Show resolved Hide resolved
@sfc-gh-lsembera sfc-gh-lsembera force-pushed the lsembera/long-running-test branch 4 times, most recently from db65466 to c68517c Compare June 11, 2024 09:22
@sfc-gh-lsembera sfc-gh-lsembera force-pushed the lsembera/long-running-test branch from c68517c to 2aabdfa Compare June 11, 2024 09:24
@sfc-gh-lsembera sfc-gh-lsembera merged commit bbf9291 into master Jun 11, 2024
48 checks passed
@sfc-gh-lsembera sfc-gh-lsembera deleted the lsembera/long-running-test branch June 11, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants