Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.1.0-unshaded release #715

Closed
wants to merge 5 commits into from
Closed

v2.1.0-unshaded release #715

wants to merge 5 commits into from
+21 −19

Conversation

sfc-gh-tzhang
Copy link
Contributor

No description provided.

@sfc-gh-tzhang sfc-gh-tzhang requested review from a team as code owners March 6, 2024 06:50
sfc-gh-xhuang
sfc-gh-xhuang reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-xhuang sfc-gh-xhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lower priority item but we should figure out how to automate this such that when we release, we can do both at the same time

@sfc-gh-tzhang sfc-gh-tzhang changed the base branch from master to v2.1.0 March 6, 2024 21:51
@sfc-gh-tzhang
Copy link
Contributor Author

Looks like the branch is created on master, let me create a new PR with the correct base

@sfc-gh-tzhang sfc-gh-tzhang deleted the v2.1.0-unshaded branch March 6, 2024 22:28
@sfc-gh-tzhang
Copy link
Contributor Author

#716 created

@sfc-gh-tzhang
Copy link
Contributor Author

sfc-gh-tzhang commented Mar 6, 2024 •
edited
Loading

LGTM, lower priority item but we should figure out how to automate this such that when we release, we can do both at the same time

Yes, I'm hoping that @sfc-gh-alhuang could help here, and I was chatting with @sfc-gh-lsembera a long time ago and ideally we want to have two artifacts like what the JDBC did for their thin jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-xhuang sfc-gh-xhuang sfc-gh-xhuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-tzhang @sfc-gh-xhuang @sfc-gh-dshah @sfc-gh-lsembera