Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-SNOW: Two minor changes that address PR comments and fix code format #679

Merged
merged 14 commits into from
Feb 21, 2024
Merged

NO-SNOW: Two minor changes that address PR comments and fix code format #679

merged 14 commits into from
Feb 21, 2024

Conversation

sfc-gh-tzhang
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang requested review from a team as code owners February 20, 2024 21:37
@sfc-gh-tzhang
Copy link
Contributor Author

@sfc-gh-tjones @sfc-gh-afedorov FYI

sfc-gh-japatel
sfc-gh-japatel reviewed Feb 20, 2024
View reviewed changes
src/main/java/net/snowflake/ingest/streaming/internal/FileColumnProperties.java
@@ -231,7 +231,7 @@ public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
FileColumnProperties that = (FileColumnProperties) o;
return Objects.equals(columnOrdinal,that.columnOrdinal)
return Objects.equals(columnOrdinal, that.columnOrdinal)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recent format.sh script suggested me these changes as well.
ahh do you know why it passed in previous PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, i don't know why it passed the format gate

sfc-gh-japatel
sfc-gh-japatel approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I will let you push first to not have my PR bloated up.
FYI: testFlushHelper is failing

@sfc-gh-tzhang sfc-gh-tzhang merged commit 63eda37 into master Feb 21, 2024
12 checks passed
@sfc-gh-tzhang sfc-gh-tzhang deleted the tzhang-si-overflow branch February 21, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-xhuang sfc-gh-xhuang sfc-gh-xhuang approved these changes

@sfc-gh-tjones sfc-gh-tjones sfc-gh-tjones approved these changes

@sfc-gh-japatel sfc-gh-japatel sfc-gh-japatel approved these changes

@sfc-gh-azagrebin sfc-gh-azagrebin Awaiting requested review from sfc-gh-azagrebin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-tzhang @sfc-gh-japatel @sfc-gh-tjones @sfc-gh-xhuang