Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-SNOW: Deprecate BUFFER_FLUSH_INTERVAL_IN_MILLIS parameter #659

Merged
merged 4 commits into from
Jan 9, 2024
Merged

NO-SNOW: Deprecate BUFFER_FLUSH_INTERVAL_IN_MILLIS parameter #659

merged 4 commits into from
Jan 9, 2024

Conversation

sfc-gh-tzhang
Copy link
Contributor

  • After MAX_CLIENT_LAG was introduced, it's not backward compatible with the current logic since MAX_CLIENT_LAG_ENABLED is true by default and we won't even check for BUFFER_FLUSH_INTERVAL_IN_MILLIS. Instead of supporting backward compatible, I decide to remove BUFFER_FLUSH_INTERVAL_IN_MILLIS completely since that is an undocumented parameter. We only support MAX_CLIENT_LAG going forward and using BUFFER_FLUSH_INTERVAL_IN_MILLIS will result in an exception.
  • To match the behavior of BUFFER_FLUSH_INTERVAL_IN_MILLIS so the transition is smooth, MAX_CLIENT_LAG now also supports LONG input and input without a time unit (default will be milliseconds)
  • Some code format changes done automatically by the Google Java Format
  • Reenable some tests disabled long time ago

@sfc-gh-tzhang sfc-gh-tzhang requested review from a team as code owners January 4, 2024 00:45
sfc-gh-japatel
sfc-gh-japatel approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you

@sfc-gh-tzhang sfc-gh-tzhang merged commit bb014fc into master Jan 9, 2024
12 checks passed
@sfc-gh-tzhang sfc-gh-tzhang deleted the tzhang-si-config branch January 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-xhuang sfc-gh-xhuang sfc-gh-xhuang approved these changes

@sfc-gh-tjones sfc-gh-tjones sfc-gh-tjones approved these changes

@sfc-gh-japatel sfc-gh-japatel sfc-gh-japatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-tzhang @sfc-gh-japatel @sfc-gh-tjones @sfc-gh-xhuang