SNOW-949967 Add an optional offset token parameter for openChannel #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tjones
approved these changes
Oct 24, 2023
| @@ -40,6 +40,9 @@ public enum OnErrorOption { | |||
| // Default timezone for TIMESTAMP_LTZ and TIMESTAMP_TZ columns | |||
| private final ZoneId defaultTimezone; | |||
|
|
|||
| private final String offsetToken; | |||
| private final boolean isOffsetTokenProvided; | |||
There was a problem hiding this comment.
Could you explain why isOffsetTokenProvided is required?
There was a problem hiding this comment.
I think this is to distinguish null as an offset token vs. it not being set.
There was a problem hiding this comment.
Exactly, i want to support setting the offsetToken as null as well.
In order to distinguish between default null string vs user provided null, I am using this extra flag.
There was a problem hiding this comment.
I see, could you add a IT test for NULL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional offsetToken field to OpenChannelRequest.java which will overwrite existing offset token if provided.